Create & List Commands #135
Conversation
…rder to create a fief.
|
I've marked this as a draft for now since there's currently no link between a fief & its faction. |
src/main/kotlin/com/dansplugins/fiefs/command/fiefs/FiefsCommand.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/dansplugins/fiefs/command/fiefs/create/FiefsCreateCommand.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/dansplugins/fiefs/command/fiefs/create/FiefsCreateCommand.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/com/dansplugins/fiefs/command/TestFiefsCommand.kt
Outdated
Show resolved
Hide resolved
src/test/kotlin/com/dansplugins/fiefs/command/TestFiefsCommand.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/dansplugins/fiefs/command/fiefs/FiefsCommand.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/dansplugins/fiefs/command/fiefs/FiefsCommand.kt
Outdated
Show resolved
Hide resolved
|
|
||
| class FiefsListCommand(private val plugin: Fiefs) : CommandExecutor, TabCompleter { | ||
| override fun onCommand(sender: CommandSender, command: Command, label: String, args: Array<out String>): Boolean { | ||
| if (plugin.fiefRepository.getFiefs().isEmpty()) { |
There was a problem hiding this comment.
Assuming the fief repository will read these from the database, you may wish to be careful about threading - commands are run on the main thread, and database queries perform I/O which would cause lag spikes each time the command was run.
Additionally, I'd recommend adding another layer of abstraction in a fief service type thing (which contains any domain logic) so your command isn't interfacing directly with the database.
|
|
||
| data class Fief(private val name: String, private val ownerMfPlayerId: MfPlayerId, private val mfFactionid: MfFactionId) { | ||
| private var id = MfFiefId.generate() | ||
| private var members: MutableList<MfPlayerId> = mutableListOf() |
There was a problem hiding this comment.
Unless you're replacing the entire list, this can be a val.
Additionally, if you use a List instead of a MutableList, this class can be immutable.
id and members could probably be moved into the constructor and given a default value.
The changes in this PR allow players to create fiefs & view a list of all fiefs on the server.
Additional Changes
closes #116
closes #117